jarjar/rustlings
1
0
Fork 0
mirror of https://github.com/rust-lang/rustlings.git synced 2026-01-02 08:49:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid initializing nested Git repository

Browse Source 
Previously a Git repository was initialized if a Cargo workspace was
detected. However, it's also possible for users to initialize rustlings
in an existing Git repository that doesn't contain a Cargo workspace.
In that case, it's still undesirable to initialize a nested Git
repository for rustlings. We therefore call Git directly to determine
if rustlings is being initialized in an existing Git repository.
This commit is contained in:
Remo Senekowitsch 2025-09-10 18:19:41 +02:00
parent 2af9e89ba5
commit 7187ad6679
No known key found for this signature in database
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/init.rs
View File

@ -28,6 +28,15 @@ pub fn init() -> Result<()> {
bail!(RUSTLINGS_DIR_ALREADY_EXISTS_ERR); bail!(RUSTLINGS_DIR_ALREADY_EXISTS_ERR);
} }
let is_inside_git_repository = Command::new("git")
.arg("rev-parse")
.stdin(Stdio::null())
.stdout(Stdio::null())
.stderr(Stdio::null())
.status()
// in case of error, assume not in Git repository
.is_ok_and(|status| status.success());
let locate_project_output = Command::new("cargo") let locate_project_output = Command::new("cargo")
.arg("locate-project") .arg("locate-project")
.arg("-q") .arg("-q")
@ -58,7 +67,7 @@ pub fn init() -> Result<()> {
} }
let mut stdout = io::stdout().lock(); let mut stdout = io::stdout().lock();
let mut init_git = true; let mut init_git = !is_inside_git_repository;
if locate_project_output.status.success() { if locate_project_output.status.success() {
if Path::new("exercises").exists() && Path::new("solutions").exists() { if Path::new("exercises").exists() && Path::new("solutions").exists() {