From 41f60c4e910aefc056ade7d8c7ab64713bec9f0d Mon Sep 17 00:00:00 2001 From: manmen-mi Date: Tue, 26 May 2026 09:56:51 +0900 Subject: [PATCH] do not leak string, use String --- src/app_state.rs | 6 +++--- src/exercise.rs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/app_state.rs b/src/app_state.rs index 8952db75..2c419825 100644 --- a/src/app_state.rs +++ b/src/app_state.rs @@ -92,9 +92,9 @@ impl AppState { .into_iter() .map(|exercise_info| { let hint = if let Some(replacer) = &url_replacer { - replacer.replace(exercise_info.hint.trim_ascii()).leak() + replacer.replace(exercise_info.hint.trim_ascii()) } else { - exercise_info.hint.trim_ascii() + exercise_info.hint.trim_ascii().to_string() }; let canonical_path = dir_canonical_path.as_deref().map(|dir_canonical_path| { @@ -628,7 +628,7 @@ mod tests { canonical_path: None, test: false, strict_clippy: false, - hint: "", + hint: String::new(), done: false, } } diff --git a/src/exercise.rs b/src/exercise.rs index b969c69a..7732e1a2 100644 --- a/src/exercise.rs +++ b/src/exercise.rs @@ -73,7 +73,7 @@ pub struct Exercise { pub canonical_path: Option, pub test: bool, pub strict_clippy: bool, - pub hint: &'static str, + pub hint: String, pub done: bool, }