jarjar/rustlings
1
0
Fork 0
mirror of https://github.com/rust-lang/rustlings.git synced 2025-12-28 06:49:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

try_from_into.rs: Improve slice implementation

Browse Source 
Using pattern matching, we can reduce four bound checks to just one.
This commit is contained in:
Eugen 2025-11-29 19:24:55 +09:00 committed by GitHub
parent b5d440fdc3
commit 0bed579a4b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
solutions/23_conversions/try_from_into.rs
View File

@ -52,13 +52,12 @@ impl TryFrom<&[i16]> for Color {
type Error = IntoColorError; type Error = IntoColorError;
fn try_from(slice: &[i16]) -> Result<Self, Self::Error> { fn try_from(slice: &[i16]) -> Result<Self, Self::Error> {
// Check the length. if let &[red, green, blue] = slice {
if slice.len() != 3 { // Reuse the implementation for a tuple.
return Err(IntoColorError::BadLen); Self::try_from((red, green, blue))
} else {
Err(IntoColorError::BadLen)
} }
// Reuse the implementation for a tuple.
Self::try_from((slice[0], slice[1], slice[2]))
} }
} }